Skip to content

[debug-certificate-mangaer] remove shell integration timeout and make make activation event more specific#5322

Merged
bmiddha merged 4 commits intomainfrom
bmiddha/vscode-tls/shell-timeout
Aug 26, 2025
Merged

[debug-certificate-mangaer] remove shell integration timeout and make make activation event more specific#5322
bmiddha merged 4 commits intomainfrom
bmiddha/vscode-tls/shell-timeout

Conversation

@bmiddha
Copy link
Member

@bmiddha bmiddha commented Aug 26, 2025

Summary

Remove timeout for VS Code shell integration
Make activation event more specific

Details

We had reports where users of the Debug Certificate Manger VS Code extension kept running into shell integration timeouts. This can happen when the shell boot up.
Shell integration is activated after the config files are sourced. So if there is anything in the .bashrc or .bash_profile that takes a while then the bash shell integration will be delayed.

We also had cases where the extension does not activate even when .vscode/debug-certificate-manager.json
Extension host logs:

2025-08-26 13:51:17.935 [info] Not activating extension 'ms-RushStack.debug-certificate-manager': Timed out while searching for 'workspaceContains' pattern .vscode/debug-certificate-manager.json

Updated activation event to be more specific in the file pattern. Hopefully this will make the search faster and not timeout.

How it was tested

Tested by adding sleep 10 to .bashrc

Tested that the extension still activates with the new pattern

2025-08-26 14:35:12.672 [info] ExtensionService#_doActivateExtension ms-RushStack.debug-certificate-manager, startup: true, activationEvent: 'workspaceContains:/.vscode/debug-certificate-manager.json'

@bmiddha bmiddha changed the title [debug-certificate-mangaer] bump shell integration timeout [debug-certificate-mangaer] remove shell integration timeout and make make activation event more specific Aug 26, 2025
@bmiddha bmiddha enabled auto-merge (squash) August 26, 2025 21:51
@bmiddha bmiddha merged commit b867db5 into main Aug 26, 2025
5 checks passed
@bmiddha bmiddha deleted the bmiddha/vscode-tls/shell-timeout branch August 26, 2025 22:07
@github-project-automation github-project-automation bot moved this from Needs triage to Closed in Bug Triage Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants